Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Island stuck on version update #857

Closed
VakarisZ opened this issue Oct 12, 2020 · 5 comments
Closed

Island stuck on version update #857

VakarisZ opened this issue Oct 12, 2020 · 5 comments
Assignees
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island.

Comments

@VakarisZ
Copy link
Contributor

VakarisZ commented Oct 12, 2020

Describe the bug

If island has no connection to the internet, the version update gets stuck waiting for the timeout and user can't do anything on the island on the meantime. Related #858

To Reproduce

Steps to reproduce the behavior:

  1. Run island without internet connection
  2. Refresh the island page
  3. On each refresh island tries to query for version update and hangs until timeout is reached. Hanging occurs because Tornado WSGI container (as noted in a warning here) is blocking/synchronous server. All other requests doesn't get parsed until version update timeout is reached and execution gets resumed.

Expected behavior

Version update process should happen in parallel with other activities on the island.

@VakarisZ VakarisZ added the Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. label Oct 12, 2020
@VakarisZ VakarisZ mentioned this issue Oct 12, 2020
4 tasks
@acepace
Copy link
Contributor

acepace commented Oct 14, 2020

Why not just add a real timeout (say less than 10 seconds)? This is anyway a good practice regardless of gevent.

@VakarisZ
Copy link
Contributor Author

Current timeout is already set (to 15 seconds I think).

@VakarisZ
Copy link
Contributor Author

Hopefully gevent solved this for good

@mssalvatore
Copy link
Collaborator

Hopefully gevent solved this for good

Have we run a test to try and reproduce this since the gevent changes?

@VakarisZ
Copy link
Contributor Author

Just checked, it's solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island.
Projects
None yet
Development

No branches or pull requests

3 participants