Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge install_mongo and deployment scripts #551

Closed
danielguardicore opened this issue Feb 23, 2020 · 4 comments · May be fixed by magnologan/monkey#2
Closed

Merge install_mongo and deployment scripts #551

danielguardicore opened this issue Feb 23, 2020 · 4 comments · May be fixed by magnologan/monkey#2
Assignees
Labels
Beginner friendly New to the project? This issue is good for you! Complexity: Low Impact: Low QA Issues relating to Quality Assurance and testing

Comments

@danielguardicore
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently installation on Linux is split into two scripts. Deployment and mongo installation. This leads to their configuration files also being split and makes it hard to CR.

Describe the solution you'd like
Single file all the things.

@danielguardicore danielguardicore added Island Beginner friendly New to the project? This issue is good for you! Documentation Issues relating to the project's documentation like readme files, guides, etc. QA Issues relating to Quality Assurance and testing labels Feb 23, 2020
@danielguardicore danielguardicore self-assigned this Feb 23, 2020
@danielguardicore
Copy link
Contributor Author

@VakarisZ Opened the issue though notice that install_mongo happens as part of the deb installation and not standalone :(

@ashish493
Copy link

Then to prevent any bugs, I think, we need to write the combined deployment script from scratch...

@VakarisZ
Copy link
Contributor

I think it's easier to update broken links and debug when there's a single source of truth. We can keep the installation script split up into different files, but there should only be one config and all scripts should be in the same dir, which is not the case currently.

@mssalvatore
Copy link
Collaborator

It's been useful to have these scripts separate. Additionally, the configuration has changed, which may have alleviated some of the original concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beginner friendly New to the project? This issue is good for you! Complexity: Low Impact: Low QA Issues relating to Quality Assurance and testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants