Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Monkey agent binaries are missing, Monkey Island shows no indication #485

Closed
ShayNehmad opened this issue Nov 10, 2019 · 0 comments · Fixed by #670 · May be fixed by magnologan/monkey#2
Closed

If Monkey agent binaries are missing, Monkey Island shows no indication #485

ShayNehmad opened this issue Nov 10, 2019 · 0 comments · Fixed by #670 · May be fixed by magnologan/monkey#2
Assignees
Labels
Beginner friendly New to the project? This issue is good for you! UI User Interface

Comments

@ShayNehmad
Copy link
Contributor

Describe the bug
When the Monkey agent binary is missing, the Island shows no clear indication as to WHY it is failing to run, instead only producing this log:

2019-11-10 16:12:16,361 - local_run.py:41 - run_local_monkey() - ERROR - Copy file failed
Traceback (most recent call last):
  File "/var/monkey_island/monkey_island/cc/resources/local_run.py", line 38, in run_local_monkey
    copyfile(monkey_path, target_path)
  File "/home/user/projects/monkey/lib/python3.6/shutil.py", line 120, in copyfile
    with open(src, 'rb') as fsrc:
FileNotFoundError: [Errno 2] No such file or directory: '/var/monkey_island/monkey_island/cc/binaries/monkey-linux-64'
2019-11-10 16:12:16,361 - wsgi.py:196 -       _log() - INFO - 200 POST /api/local-monkey (::1) 1.63ms

To Reproduce
Steps to reproduce the behavior:

  1. Set up Monkey Island without the Monkey Binaries
  2. Press "Run on Monkey Island"
  3. Nothing happens
  4. See error in logs

Expected behavior
The Island should pop up an error message to the user explaining what happened and how to fix it/contact us.

Screenshots/logs

2019-11-10 16:12:16,361 - local_run.py:41 - run_local_monkey() - ERROR - Copy file failed
Traceback (most recent call last):
  File "/var/monkey_island/monkey_island/cc/resources/local_run.py", line 38, in run_local_monkey
    copyfile(monkey_path, target_path)
  File "/home/user/projects/monkey/lib/python3.6/shutil.py", line 120, in copyfile
    with open(src, 'rb') as fsrc:
FileNotFoundError: [Errno 2] No such file or directory: '/var/monkey_island/monkey_island/cc/binaries/monkey-linux-64'
2019-11-10 16:12:16,361 - wsgi.py:196 -       _log() - INFO - 200 POST /api/local-monkey (::1) 1.63ms

Thanks @liad-guardicore for letting us know

@ShayNehmad ShayNehmad added Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Island UI User Interface labels Nov 10, 2019
@ShayNehmad ShayNehmad self-assigned this Nov 10, 2019
@ShayNehmad ShayNehmad changed the title If Monkey agent binaries are missing, Monkey Island should no indication of it If Monkey agent binaries are missing, Monkey Island shows no indication Nov 12, 2019
@VakarisZ VakarisZ added the Beginner friendly New to the project? This issue is good for you! label Mar 9, 2020
@ShayNehmad ShayNehmad removed the Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. label Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beginner friendly New to the project? This issue is good for you! UI User Interface
Projects
None yet
3 participants