Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate credentials in DAL model file #332

Closed
ShayNehmad opened this issue May 28, 2019 · 1 comment
Closed

Populate credentials in DAL model file #332

ShayNehmad opened this issue May 28, 2019 · 1 comment
Labels
Code Quality Deficiencies in code quality Complexity: Low Impact: Low

Comments

@ShayNehmad
Copy link
Contributor

Populate the Creds class in monkey_island/cc/models/creds.py with its actual data fields, extract relevant logic to model class:

  • add_credentials_to_node
  • add_credentials_to_monkey
  • resources/monkey.py:monkey:post

and add unit tests in models/test_creds.py
@snyk-bot snyk-bot mentioned this issue Jul 15, 2020
Merged
@VakarisZ VakarisZ removed the Island label Feb 25, 2021
@mssalvatore mssalvatore removed the DAL label Oct 25, 2022
@mssalvatore
Copy link
Collaborator

The credentials subsystem has been entirely replaced. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Quality Deficiencies in code quality Complexity: Low Impact: Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mssalvatore @VakarisZ @ShayNehmad