Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB: missing logs #2362

Closed
6 tasks done
VakarisZ opened this issue Sep 28, 2022 · 2 comments · Fixed by #2384
Closed
6 tasks done

BB: missing logs #2362

VakarisZ opened this issue Sep 28, 2022 · 2 comments · Fixed by #2384
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Complexity: Medium Impact: High Refactor

Comments

@VakarisZ
Copy link
Contributor

VakarisZ commented Sep 28, 2022

Describe the bug

Logs are empty:
image

To Reproduce

Steps to reproduce the behavior:

  1. Run any BB ete test (passing or failing)
  2. Download logs (they are empty)

Expected behavior

Logs should get downloaded as they did before

Tasks

  • Decide on a format for the log file name (0d) @mssalvatore
  • Add an endpoint to get all agents (GET /api/agents) (0d) @mssalvatore
    • Don't forget the changelog
  • Add an endpoint to get all machines (GET /api/machines) (0d) @cakekoa
    • Don't forget the changelog
  • Modify the BB tests to get log for each agent. Name the log files and write them out. (0d) @mssalvatore
@VakarisZ VakarisZ added the Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. label Sep 28, 2022
@mssalvatore
Copy link
Collaborator

This is likely a result of #2274

@mssalvatore
Copy link
Collaborator

mssalvatore commented Sep 30, 2022

We'll use agent-{START_TIME}-{IP}.log for agent log names.

"agent" is added to distinguish agent from island logs.

Having the start time in the log could be useful during debugging. It will also allow log files to be sorted by name and appear in chronological order.

The IP is enough to uniquely identify machines for our test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Complexity: Medium Impact: High Refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants