Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor /api/island-mode #2106

Closed
5 of 7 tasks
mssalvatore opened this issue Jul 22, 2022 · 0 comments · Fixed by #2143 or #2145
Closed
5 of 7 tasks

Refactor /api/island-mode #2106

mssalvatore opened this issue Jul 22, 2022 · 0 comments · Fixed by #2143 or #2145
Labels
Complexity: Low Impact: Low Refactor

Comments

@mssalvatore
Copy link
Collaborator

mssalvatore commented Jul 22, 2022 •
edited
Loading

Refactor

Component(s) to be refactored

  • /api/island-mode

Tasks

  • Rename to /api/island/mode (0d) @ilija-lazoroski
  • Change POST to PUT (0d) @ilija-lazoroski
  • Use HTTPStatus enum for return codes (0d) @ilija-lazoroski
    • See if you can just return the status with no body
    • Use 204 instead of 200 for PUT
  • Get rid of ['mode'] in api/island/mode and all uses. (0.25d) @ilija-lazoroski
    • Add IslandMode to resources/__init__.py and shorten all imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Complexity: Low Impact: Low Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2106 refactor island mode guardicore/monkey
2106 remove mode keyword guardicore/monkey
2 participants
@ilija-lazoroski @mssalvatore