Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor authentication endpoints #2105

Closed
12 tasks done
mssalvatore opened this issue Jul 22, 2022 · 0 comments · Fixed by #2150
Closed
12 tasks done

Refactor authentication endpoints #2105

mssalvatore opened this issue Jul 22, 2022 · 0 comments · Fixed by #2150
Labels
Complexity: Low Impact: Medium Refactor

Comments

@mssalvatore
Copy link
Collaborator

mssalvatore commented Jul 22, 2022 •
edited
Loading

Refactor

Component(s) to be refactored

  • monkey_island.cc.resources.auth.auth.Authenticate
  • monkey_island.cc.resources.auth.registation.Registration
  • monkey_island.cc.services.AuthenticationService

Tasks

  • Rename endpoints (0d) - @shreyamalviya
    • Rename /api/auth to /api/authenticate
    • Rename resources/auth/auth.py to resources/auth/authenticate.py
    • Rename /api/registration to /api/register
    • Rename resources/auth/registration.py to resources/auth/register.py
  • Remove unneccesary "error" in /api/authenticate response (0d) - @shreyamalviya
  • Add /api/user-registration-status to check whether or not registration is needed (0d) - @shreyamalviya
    • Remove GET /api/registration
  • Add docstrings (0d) - @shreyamalviya
    • AuthenticationService
    • /api/authenticate
    • /api/register
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Complexity: Low Impact: Medium Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add docstrings to auth endpoints guardicore/monkey
1 participant
@mssalvatore