Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove export_monkey_telems from the configuration #1998

Closed
1 of 2 tasks
mssalvatore opened this issue Jun 8, 2022 · 0 comments · Fixed by #2013
Closed
1 of 2 tasks

Remove export_monkey_telems from the configuration #1998

mssalvatore opened this issue Jun 8, 2022 · 0 comments · Fixed by #2013
Assignees
@shreyamalviya
Labels
Complexity: Medium Impact: Medium Refactor sp/2

Comments

@mssalvatore
Copy link
Collaborator

mssalvatore commented Jun 8, 2022 •
edited by shreyamalviya
Loading

Refactor

Component(s) to be refactored

  • configuration

Explanation

  1. export_monkey_telems is used by the island, not the agent. It does not belong in the agent configuration.
  2. TestTelemStore is the only component that uses this configuration option. We are planning better ways of achieving the same goal.

Tasks

  • Remove TestTelemStore (0.25d)
  • Remove export_monkey_telems from the configuration schema (0d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shreyamalviya shreyamalviya

Labels
Complexity: Medium Impact: Medium Refactor sp/2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove export_monkey_telems guardicore/monkey
2 participants
@mssalvatore @shreyamalviya