Skip to content
This repository has been archived by the owner on Sep 8, 2021. It is now read-only.

Replace Live with LiveBlog and DeadBlog #83

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Conversation

oliverlloyd
Copy link
Contributor

What?

Replaces Design.Live with Design.LiveBlog and Design.DeadBlog

Why?

Because there are two distinct styles for live blogs, those that are live or active, and historical live blogs that are no longer live or active.

And also because at the moment, liveblogs are represented by CAPI using booleans and we want to bring these articles into the model.

CAPI LiveBlog

{
  designType: 'Article',
  config: {
    isLiveBlog: true,
    isLive: true,
  }
}

CAPI DeadBlog

{
  designType: 'Article',
  config: {
    isLiveBlog: true,
    isLive: false,
  }
}

Dead?

The nomenclature of 'DeadBlog' exists already in Frontend where it is used for Cards and whilst 'dead' is a bit morbid it's the correct antonym for 'live'.

LiveBlog

Screenshot 2021-02-22 at 08 15 03

DeadBlog

Screenshot 2021-02-22 at 08 16 55

@oliverlloyd
Copy link
Contributor Author

DeadBlog

Copy link

@liywjl liywjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have never really though much about the antithesis of LiveBlog so the name DeadBlog sounded a bit odd at first. But the more I think about it, the more I am coming around to it.

I like the name 👍

Copy link

@Akhaides1881 Akhaides1881 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can work well. with oracle I'm not sure if it is compatible.

@oliverlloyd
Copy link
Contributor Author

I think this can work well. with oracle I'm not sure if it is compatible.

Hey @Akhaides1881 👋 thanks for the comment! However, I think you might have meant to be looking at a different Guardian repo, I see your account is under https://github.com/Seven-Guardians? We certainly don't use Oracle around here (or at least not that I know of!).

Welcome, nonetheless 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants