This repository has been archived by the owner on Jun 15, 2021. It is now read-only.
Fix breaking out of <p> when deleting across paragraphs in FF #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,7 @@ | |||
| "plumber-write": "~0.2.0", | |||
| "q": "~1.0.0", | |||
| "request": "~2.33.0", | |||
| "selenium-webdriver": "~2.37.0" | |||
| "selenium-webdriver": "^2.41.0" | |||
There was a problem hiding this comment.
The caret, on the other hand, is more relaxed. It will update you to the most recent major version (the first number). ^1.2.3 will match any 1.x.x release including 1.3.0, but will hold off on 2.0.0.
http://fredkschott.com/post/2014/02/npm-no-longer-defaults-to-tildes/
|
It looks like you forgot to commit |
|
Sadly Travis is being slow: https://travis-ci.org/guardian/scribe/branches |
|
@OliverJAsh ping |
|
|
||
| var realChangedNodes = allChangedNodes. | ||
| filter(notEmptyTextNode). | ||
| filter(notSelectionMarkerNode); |
|
Looks good! Nice work, love the use of DOM |
|
Tests passed, let's release this! |
theefer
added a commit
that referenced
this pull request
Apr 11, 2014
Fix breaking out of <p> when deleting across paragraphs in FF
|
Please do follow this up with an isolated case. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.