From b949f0afa16449675741ba31e9a66b5d7775d0ed Mon Sep 17 00:00:00 2001 From: Mahesh Makani Date: Wed, 27 Jul 2022 16:17:19 +0100 Subject: [PATCH] feat(ophan): add additional types to `OphanAction` The identity team use the `SIGN_IN` and `CREATE_ACCOUNT` action, which we noticed was missing from the `OphanAction` type despite them being defined in https://dashboard.ophan.co.uk/docs/thrift/componentevent.html#Enum_Action This commit adds those actions in so that they're available for use. --- src/ophan/@types/index.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/ophan/@types/index.ts b/src/ophan/@types/index.ts index a2b326ac..1ed47724 100644 --- a/src/ophan/@types/index.ts +++ b/src/ophan/@types/index.ts @@ -39,7 +39,9 @@ export type OphanAction = | 'CONSENT_REJECT_ALL' | 'STICK' | 'CLOSE' - | 'RETURN'; + | 'RETURN' + | 'SIGN_IN' + | 'CREATE_ACCOUNT'; export type OphanComponentType = | 'READERS_QUESTIONS_ATOM' @@ -66,7 +68,8 @@ export type OphanComponentType = | 'RETENTION_EPIC' | 'CONSENT' | 'LIVE_BLOG_PINNED_POST' - | 'STICKY_VIDEO'; + | 'STICKY_VIDEO' + | 'IDENTITY_AUTHENTICATION'; export type OphanComponent = { componentType: OphanComponentType;