Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

perf!: Import helpers from tslib #391

Merged
merged 6 commits into from
Aug 30, 2022
Merged

perf!: Import helpers from tslib #391

merged 6 commits into from
Aug 30, 2022

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Aug 24, 2022

What does this change?

stops bundling helpers from tslib in the published code

Why?

consumers can publish smaller bundles

Before

var __classPrivateFieldSet = (this && this.__classPrivateFieldSet) || function (receiver, privateMap, value) {
    if (!privateMap.has(receiver)) {
        throw new TypeError("attempted to set private field on non-instance");
    }
    privateMap.set(receiver, value);
    return value;
};
var __classPrivateFieldGet = (this && this.__classPrivateFieldGet) || function (receiver, privateMap) {
    if (!privateMap.has(receiver)) {
        throw new TypeError("attempted to get private field on non-instance");
    }
    return privateMap.get(receiver);
};

After

import { __classPrivateFieldGet, __classPrivateFieldSet } from "tslib";

@sndrs sndrs requested a review from a team as a code owner August 24, 2022 12:08
@coveralls
Copy link

coveralls commented Aug 24, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling f683058 on tslib-external into 276516f on main.

ob6160
ob6160 previously approved these changes Aug 24, 2022
@mxdvl
Copy link
Contributor

mxdvl commented Aug 25, 2022

What happened with the whitespace changes?

@sndrs
Copy link
Member Author

sndrs commented Aug 30, 2022

What happened with the whitespace changes?

wow i really don't know! sorry about that, should be fixed now

@sndrs sndrs enabled auto-merge (squash) August 30, 2022 11:26
@sndrs sndrs merged commit f9db5e5 into main Aug 30, 2022
@sndrs sndrs deleted the tslib-external branch August 30, 2022 11:41
@github-actions
Copy link

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants