Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

feat(logger): add identity team to logger #385

Merged
merged 1 commit into from
Aug 11, 2022
Merged

feat(logger): add identity team to logger #385

merged 1 commit into from
Aug 11, 2022

Conversation

coldlink
Copy link
Member

@coldlink coldlink commented Aug 9, 2022

What does this change?

Add the Identity team to the logger

Why?

So the Identity team can use these logs to identify their own logs in other platforms, e.g. frontend/dcr, as well as our own.

@coldlink coldlink requested a review from a team as a code owner August 9, 2022 14:08
@coveralls
Copy link

coveralls commented Aug 9, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling 75f570e on mm/logger-identity into 3b08f4d on main.

Copy link
Member

@sndrs sndrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is a feat rather than a fix? all good apart from that

@coldlink coldlink force-pushed the mm/logger-identity branch from d1bdca1 to 75f570e Compare August 10, 2022 13:17
@coldlink coldlink changed the title fix(logger): add identity team to logger feat(logger): add identity team to logger Aug 10, 2022
@coldlink
Copy link
Member Author

Thanks! That makes sense, updated commit/pr to feat

@sndrs sndrs merged commit 9e86742 into main Aug 11, 2022
@sndrs sndrs deleted the mm/logger-identity branch August 11, 2022 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants