This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
fix: remove type assertions from logger #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxdvl
force-pushed
the
mxdvl/logger-no-assertion
branch
from
cfbf341 to
5bbe3e2
Compare
mxdvl
force-pushed
the
mxdvl/logger-no-assertion
branch
2 times, most recently
from
795bb96 to
2071777
Compare
extract common team styles out of team ones extract `getTeamSubscriptions`, which is type-safe
mxdvl
force-pushed
the
mxdvl/logger-no-assertion
branch
from
2071777 to
5369e4e
Compare
sndrs
approved these changes
Aug 30, 2022
|
🎉 This PR is included in version 7.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Remove type assertions from logger by creating a
getTeamSubscriptionsabstraction.Why?
Checks unkown value at runtime for better type safety.