This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
feat(ophan): add additional types to Ophan #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldlink
force-pushed
the
mm/identity-ophan
branch
2 times, most recently
from
456ff99 to
b6db5f9
Compare
coldlink
changed the title
OphanAction
The identity team use the `SIGN_IN` and `CREATE_ACCOUNT` action, which we noticed was missing from the `OphanAction` type despite them being defined in https://dashboard.ophan.co.uk/docs/thrift/componentevent.html#Enum_Action This commit adds those actions in so that they're available for use.
coldlink
force-pushed
the
mm/identity-ophan
branch
from
b6db5f9 to
b949f0a
Compare
coldlink
changed the title
sndrs
approved these changes
Jul 28, 2022
|
🎉 This PR is included in version 6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
The identity team use the
SIGN_INandCREATE_ACCOUNTaction, which we noticed was missing from theOphanActiontype, and theIDENTITY_AUTHENTICATIONOphanCompnenttype.From the definitions in https://dashboard.ophan.co.uk/docs/thrift/componentevent.html
This PR adds those actions in so that they're available for use.