Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply correct colourspace conversion when generating on-the-fly preview #894

Open
theefer opened this issue Jul 1, 2015 · 8 comments
Open

Comments

@theefer
Copy link
Contributor

theefer commented Jul 1, 2015

Not sure how to do this as it's a different conversion path (via nginx module), but let's see if we can think of a way.

See also #784

@paperboyo
Copy link
Contributor

Unfortunately, depends on libgd/libgd#136 (https://bitbucket.org/libgd/gd-libgd/issues/136) :sadpanda:

@paperboyo
Copy link
Contributor

Hmm, I wouldn’t know, but is this a possible replacement? ngx_http_image_filter_module not only messes up colour, but also chokes on big images. AWS alternative uses sharp which in turn uses libvips which we wanted to have a look at separately as a replacement for GM. From what I can tell, it supports colour management. And promises to be super-fast.

@paperboyo
Copy link
Contributor

paperboyo commented Feb 1, 2019

@akash1810 Because Firefox now supports WebP and because libgd/libgd#136 (comment), maybe we could ask for WebPs? This might have an additional advantage of not having to use optimisedPng intermediary asset for cutouts. WDYT?

@paperboyo
Copy link
Contributor

paperboyo commented Feb 7, 2019

It looks like we would need another nginx module: pagespeed.

Although they say that any conversion/resize removes colour profile. Let’s hope they have no idea what are they talking about (which a non-mention of profile conversion prior to profile removal luckily suggests) and that the above comment still holds.

@sihil sihil added the To Review PRs that need to be reviewed label Sep 8, 2020
@paperboyo paperboyo removed the To Review PRs that need to be reviewed label Sep 8, 2020
@paperboyo
Copy link
Contributor

Not sure, but maybe https://github.com/imazen/imageflow can help here? Or in #155. Or – both?

@paperboyo
Copy link
Contributor

paperboyo commented Feb 7, 2021

@paperboyo
Copy link
Contributor

@paperboyo
Copy link
Contributor

paperboyo commented Jan 30, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants