Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Dark Mode To Beta #9754

Closed
JamieB-gu opened this issue Dec 4, 2023 · 0 comments
Closed

Release Dark Mode To Beta #9754

JamieB-gu opened this issue Dec 4, 2023 · 0 comments

Comments

@JamieB-gu
Copy link
Contributor

Once most of the dark mode tickets are done, enough to render a full article in dark mode, we can flip the switch1 to enable dark mode in the beta.

Any article formats or features from the list in #9110 that are not yet supported can be added to the filter in MAPI2, so that they don't appear broken in dark mode. Then, as we add dark mode support to each of them, the filter can be updated to allow them in beta.

Footnotes

  1. https://github.com/guardian/frontend/blob/a06fec0344cf61e40b22cd55614fa9d248fb2c9b/common/app/conf/switches/FeatureSwitches.scala#L525-L534

  2. https://github.com/guardian/mobile-apps-api/blob/main/common-play/src/main/scala/data/DcrSupportUtils.scala

@JamieB-gu JamieB-gu added this to the DCR for Apps milestone Dec 4, 2023
@github-project-automation github-project-automation bot moved this to Triage in WebX Team Dec 4, 2023
@shesah shesah moved this from Triage to Done in WebX Team Dec 14, 2023
@shesah shesah closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants