Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darkmode - Drop caps colour #9618

Closed
Tracked by #9110
sophie-macmillan opened this issue Nov 23, 2023 · 0 comments · Fixed by #9630
Closed
Tracked by #9110

Darkmode - Drop caps colour #9618

sophie-macmillan opened this issue Nov 23, 2023 · 0 comments · Fixed by #9630
Assignees
@DanielCliftonGuardian
Milestone
DCAR Migration

Comments

@sophie-macmillan
Copy link
Contributor

sophie-macmillan commented Nov 23, 2023 •
edited
Loading

These are not the same colour in AR and DCAR. We should update DCAR to the correct colour (or confirm with design that the current one is ok). We should definitely make sure the darker colour has good contrast if thats what we go with.

In DCAR:
image
(We might need to also update the comment button)

In AR:
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielCliftonGuardian DanielCliftonGuardian

Labels
None yet
Projects
WebX Team
Archived in project
Milestone
DCAR Migration
Development

Successfully merging a pull request may close this issue.

Dropcap Darkmode guardian/dotcom-rendering
2 participants
@sophie-macmillan @DanielCliftonGuardian