Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Darkmode for discussion #10331

Closed
13 tasks done
Tracked by #8745
alinaboghiu opened this issue Jan 25, 2024 · 4 comments
Closed
13 tasks done
Tracked by #8745

[EPIC] Darkmode for discussion #10331

alinaboghiu opened this issue Jan 25, 2024 · 4 comments

Comments

@alinaboghiu
Copy link
Member

alinaboghiu commented Jan 25, 2024

Ensure Discussion components are compatible with dark mode.

Please refer to this Figma file with details for the tweaks. The task list crashes when I start adding tasks it so I won't rely on it for detailed stuff.

Tasks

  1. cemms1
  2. Discussion
    ioannakok
  3. Discussion
    DanielCliftonGuardian
  4. Discussion
    DanielCliftonGuardian
  5. abeddow91
  6. DanielCliftonGuardian
  7. DanielCliftonGuardian
  8. Discussion
    abeddow91
  9. Discussion
    abeddow91
  10. Discussion
    abeddow91
  11. Discussion
    DanielCliftonGuardian
  12. Discussion
    abeddow91
  13. Discussion
    abeddow91
@github-project-automation github-project-automation bot moved this to Triage in WebX Team Jan 25, 2024
@alinaboghiu alinaboghiu added this to the DCR for Apps milestone Jan 25, 2024
@alinaboghiu alinaboghiu moved this from Triage to This Sprint in WebX Team Jan 25, 2024
@shesah
Copy link

shesah commented Jan 30, 2024

@benwuersching are you currently working on this?

@cemms1
Copy link
Contributor

cemms1 commented Feb 7, 2024

Storybook link is here to check dark mode compatibility for Discussion components. Searching for "discussion" in the left hand panel makes it easier to find the discussion-related components

@cemms1 cemms1 self-assigned this Feb 7, 2024
@cemms1 cemms1 moved this from This Sprint to In Progress in WebX Team Feb 7, 2024
@cemms1
Copy link
Contributor

cemms1 commented Feb 8, 2024

Chromatic build link here https://www.chromatic.com/build?appId=63e251470cfbe61776b0ef19&number=6762

@benwuersching is going to review the Storybook link and these changes and then suggest some improvements for the dark mode designs

@cemms1 cemms1 changed the title Darkmode for discussion [EPIC] Darkmode for discussion Feb 12, 2024
@cemms1
Copy link
Contributor

cemms1 commented Feb 12, 2024

Have split out the preliminary work to add basic dark mode compatibility to Discussion components from this ticket and converted this to an epic ticket to detail the design optimisations for dark mode components

@cemms1 cemms1 removed their assignment Feb 14, 2024
@cemms1 cemms1 self-assigned this Feb 23, 2024
@cemms1 cemms1 removed their assignment Feb 23, 2024
@JamieB-gu JamieB-gu moved this from In Progress to This Sprint in WebX Team Feb 27, 2024
@alinaboghiu alinaboghiu moved this from This Sprint to In Progress in WebX Team Feb 29, 2024
@DanielCliftonGuardian DanielCliftonGuardian moved this from In Progress to Done in WebX Team Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants