Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Discussion API On iOS #10326

Closed
6 tasks done
Tracked by #9869
alinaboghiu opened this issue Jan 25, 2024 · 2 comments
Closed
6 tasks done
Tracked by #9869

Implement Discussion API On iOS #10326

alinaboghiu opened this issue Jan 25, 2024 · 2 comments
Assignees

Comments

@alinaboghiu
Copy link
Member

alinaboghiu commented Jan 25, 2024

Tasks

  1. Discussion
    georgeblahblah
  2. Discussion
  3. Discussion
@alinaboghiu alinaboghiu added this to the DCR for Apps milestone Jan 25, 2024
@alinaboghiu alinaboghiu moved this to This Sprint in WebX Team Jan 25, 2024
@JamieB-gu JamieB-gu removed their assignment Jan 31, 2024
@georgeblahblah georgeblahblah self-assigned this Jan 31, 2024
@georgeblahblah georgeblahblah moved this from This Sprint to In Progress in WebX Team Jan 31, 2024
@mxdvl
Copy link
Contributor

mxdvl commented Feb 5, 2024

Update tomorrow (Feb 6) after pairing with iOS native dev

@georgeblahblah
Copy link
Contributor

georgeblahblah commented Feb 6, 2024

Progress so far

  • Opened a draft PR with a test implementation of the "recommend comment" feature on ios-live as an example
    • interaction with Bridget/DCAR webview is working
  • Next steps: Create modules to interact with Discussion API in exactly the way we want. The existing implementation is tightly coupled. It uses native views and handles errors using native UI.

Working on this locally

  • Check out gb/bridget-discussion on ios-live
  • Check out gb/dcar-discussion-beta on MAPI, and run mobile fronts
  • Check out gb/test-recommend-ios on DCR and run the dev server
  • Set debug settings in iOS simulator to use CODE Okta, CODE Identity, Local AR, Local MAPI fronts. Make sure you're not using the new Blueprint fronts! These don't work with beta articles

Open questions

  • Decide the "sign in" behaviour should work
  • What should the failure mode be if the user goes offline?

@georgeblahblah georgeblahblah moved this from In Progress to This Sprint in WebX Team Feb 6, 2024
@shesah shesah moved this from This Sprint to Blocked in WebX Team Feb 7, 2024
@georgeblahblah georgeblahblah moved this from Blocked to This Sprint in WebX Team Feb 14, 2024
@alinaboghiu alinaboghiu changed the title Implement iOS event handler Implement iOS event handlers Feb 27, 2024
@JamieB-gu JamieB-gu added the Epic label Feb 27, 2024
@JamieB-gu JamieB-gu changed the title Implement iOS event handlers Implement Discussion API On iOS Feb 27, 2024
@JamieB-gu JamieB-gu removed their assignment Mar 1, 2024
@alinaboghiu alinaboghiu moved this from This Sprint to Next Sprint in WebX Team Mar 25, 2024
@alinaboghiu alinaboghiu moved this from Next Sprint to This Sprint in WebX Team Apr 12, 2024
@georgeblahblah georgeblahblah moved this from This Sprint to Review in WebX Team Apr 16, 2024
@georgeblahblah georgeblahblah moved this from Review to In Progress in WebX Team Apr 17, 2024
@georgeblahblah georgeblahblah moved this from In Progress to Review in WebX Team Apr 17, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in WebX Team Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants