Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide how requests to the discussion API are handled #10071

Closed
Tracked by #8745
mxdvl opened this issue Jan 5, 2024 · 3 comments
Closed
Tracked by #8745

Decide how requests to the discussion API are handled #10071

mxdvl opened this issue Jan 5, 2024 · 3 comments

Comments

@mxdvl
Copy link
Contributor

mxdvl commented Jan 5, 2024

There are two options for making calls to the discussion API, which must be authenticated:

  1. use Bridget to make the calls and pass the response to web view
  2. use Bridget to pass the authentication down to the web view which makes the calls

Option 1 is more similar to other authenticated requests in the Apps
Option 2 is closer to how the web currently handles things

Existing stub in iOS: https://github.com/guardian/ios-live/blob/7c7762c139560c2b3ba0e7f56233c51dfa3de22d/GLA/GLA/Classes/ARArticleViewController%2BBridget.swift#L197-L207

Existing sub in Android: https://github.com/guardian/android-news-app/blob/352429b2735371051d4d7a00c6ddc73320b6f37f/android-news-app/src/main/java/com/guardian/feature/renderedarticle/bridget/DiscussionImpl.kt#L10-L35


We will probably want to implement useReducer with a different reducer implementation for each platform.

@mxdvl mxdvl added this to the DCR for Apps milestone Jan 5, 2024
@mxdvl mxdvl added this to WebX Team Jan 5, 2024
@github-project-automation github-project-automation bot moved this to Triage in WebX Team Jan 5, 2024
@mxdvl mxdvl moved this from Triage to Next Sprint in WebX Team Jan 5, 2024
@BenSullivan-iOS
Copy link

I have discussed this with the iOS team, we have a slight leaning towards option 2, however, this may cause complications when it comes to tracking

@mxdvl mxdvl moved this from Next Sprint to This Sprint in WebX Team Jan 16, 2024
@shesah
Copy link

shesah commented Jan 30, 2024

WebEx leaning towards option one - one to discuss with the Apps team and commit to an approach

@JamieB-gu
Copy link
Contributor

We're going with option 1: ask the native app to make the calls via Bridget.

@github-project-automation github-project-automation bot moved this from This Sprint to Done in WebX Team Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants