From 47d3cbdd8e3e83e9c108696e1ca374c72ad2a89c Mon Sep 17 00:00:00 2001 From: Alex Sanders Date: Thu, 15 Oct 2020 12:33:35 +0100 Subject: [PATCH 1/2] do not commit bumps to package.json in CD --- .github/workflows/CI.yml | 2 +- .releaserc.json | 3 +-- package.json | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 0a4e6456c..983b16c4d 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -121,6 +121,6 @@ jobs: - name: Release env: - GITHUB_TOKEN: ${{ secrets.RELEASE_TOKEN }} + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} NPM_TOKEN: ${{ secrets.NPM_TOKEN }} run: npx semantic-release diff --git a/.releaserc.json b/.releaserc.json index 966a8b0e7..1c497bcd8 100644 --- a/.releaserc.json +++ b/.releaserc.json @@ -5,7 +5,6 @@ "@semantic-release/release-notes-generator", "@semantic-release/changelog", "@semantic-release/npm", - "@semantic-release/github", - "@semantic-release/git" + "@semantic-release/github" ] } diff --git a/package.json b/package.json index 6e2692c25..7d13265c9 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@guardian/commercial-core", - "version": "0.8.3", + "version": "0.0.0-this-never-updates-in-source-code-look-at-git-tags", "description": "Guardian advertising business logic", "homepage": "https://github.com/guardian/commercial-core#readme", "bugs": { From e0f2a4dfa984a697a969fdfbce6d112fc0635d05 Mon Sep 17 00:00:00 2001 From: Alex Sanders Date: Thu, 15 Oct 2020 12:39:20 +0100 Subject: [PATCH 2/2] remove changelog from source --- .releaserc.json | 1 - CHANGELOG.md | 104 ------------------------------------------------ package.json | 2 - yarn.lock | 28 +------------ 4 files changed, 2 insertions(+), 133 deletions(-) delete mode 100644 CHANGELOG.md diff --git a/.releaserc.json b/.releaserc.json index 1c497bcd8..4341bfaa4 100644 --- a/.releaserc.json +++ b/.releaserc.json @@ -3,7 +3,6 @@ "plugins": [ "@semantic-release/commit-analyzer", "@semantic-release/release-notes-generator", - "@semantic-release/changelog", "@semantic-release/npm", "@semantic-release/github" ] diff --git a/CHANGELOG.md b/CHANGELOG.md deleted file mode 100644 index 4b43f33f8..000000000 --- a/CHANGELOG.md +++ /dev/null @@ -1,104 +0,0 @@ -## [0.8.3](https://github.com/guardian/commercial-core/compare/v0.8.2...v0.8.3) (2020-10-14) - - -### Bug Fixes - -* test coverage fix ([#61](https://github.com/guardian/commercial-core/issues/61)) ([be88c20](https://github.com/guardian/commercial-core/commit/be88c205d5553323a44ea14c21271ce991b461bd)) - -## [0.8.2](https://github.com/guardian/commercial-core/compare/v0.8.1...v0.8.2) (2020-10-14) - - -### Bug Fixes - -* export TPT type ([#60](https://github.com/guardian/commercial-core/issues/60)) ([cf3d6de](https://github.com/guardian/commercial-core/commit/cf3d6dee134cada558e9e41efbdbbafc0b8b593b)) - -## [0.8.1](https://github.com/guardian/commercial-core/compare/v0.8.0...v0.8.1) (2020-10-14) - - -### Bug Fixes - -* move vendor back into src ([#57](https://github.com/guardian/commercial-core/issues/57)) ([f27e108](https://github.com/guardian/commercial-core/commit/f27e1086dcf4407262e20d6ad1755f1b6325a186)) - -# [0.8.0](https://github.com/guardian/commercial-core/compare/v0.7.1...v0.8.0) (2020-10-14) - - -### Features - -* Export more lotame data ([#56](https://github.com/guardian/commercial-core/issues/56)) ([4120b69](https://github.com/guardian/commercial-core/commit/4120b69a177d0605628d89df449b3d306d5357fa)) - -## [0.7.1](https://github.com/guardian/commercial-core/compare/v0.7.0...v0.7.1) (2020-10-13) - - -### Bug Fixes - -* Create vendor dir and exclude it from coverage ([#55](https://github.com/guardian/commercial-core/issues/55)) ([85089f8](https://github.com/guardian/commercial-core/commit/85089f8396e78b4ac5f4e6f28c4f38e9696c139a)) - -# [0.7.0](https://github.com/guardian/commercial-core/compare/v0.6.0...v0.7.0) (2020-10-12) - - -### Features - -* **google remarketing tags:** added support for GoogleRemarketing tags as a thirdparty tag ([#52](https://github.com/guardian/commercial-core/issues/52)) ([97c54a9](https://github.com/guardian/commercial-core/commit/97c54a90775e493008604bef12056b43d7be5e30)) - -# [0.6.0](https://github.com/guardian/commercial-core/compare/v0.5.0...v0.6.0) (2020-09-29) - - -### Features - -* **facebook pixel:** actually export it ([c825e76](https://github.com/guardian/commercial-core/commit/c825e76d13e2f230f28d5d12831c21a358a84b53)) - -# [0.5.0](https://github.com/guardian/commercial-core/compare/v0.4.0...v0.5.0) (2020-09-29) - - -### Features - -* **third party tags:** add facebook pixel ([8ebc439](https://github.com/guardian/commercial-core/commit/8ebc4392adde8ab34d3f24c599a9910e8ea4d402)) - -# [0.4.0](https://github.com/guardian/commercial-core/compare/v0.3.0...v0.4.0) (2020-09-25) - - -### Features - -* rename flag for third party tags ([e491d55](https://github.com/guardian/commercial-core/commit/e491d5502cb7017ecdeb3ffa364992c0119a0c26)) - -# [0.3.0](https://github.com/guardian/commercial-core/compare/v0.2.4...v0.3.0) (2020-09-22) - - -### Features - -* export real things! ([1e7b907](https://github.com/guardian/commercial-core/commit/1e7b9072752a7186ce03dcf13c38d9ad369c4cd7)) - -## [0.2.4](https://github.com/guardian/commercial-core/compare/v0.2.3...v0.2.4) (2020-09-22) - - -### Bug Fixes - -* **package:** provide path config when downloading build artifect ([0d198ec](https://github.com/guardian/commercial-core/commit/0d198ec084879524f0671554c5661fac48dbfbd1)) - -## [0.2.3](https://github.com/guardian/commercial-core/compare/v0.2.2...v0.2.3) (2020-09-22) - - -### Bug Fixes - -* **package:** ensure build asset is used when packaging ([d2e258c](https://github.com/guardian/commercial-core/commit/d2e258c6b22f2654453f78074c57ae472609ffc4)) - -## [0.2.2](https://github.com/guardian/commercial-core/compare/v0.2.1...v0.2.2) (2020-09-22) - - -### Bug Fixes - -* **release:** add release to github releases too ([6926c50](https://github.com/guardian/commercial-core/commit/6926c50328da626ac2a049d17b665b6515bfa1be)) - -## [0.2.1](https://github.com/guardian/commercial-core/compare/v0.2.0...v0.2.1) (2020-09-22) - - -### Bug Fixes - -* **package:** don't publish the whole directory, just dist ([26ffe74](https://github.com/guardian/commercial-core/commit/26ffe74905196d2fde318f246f67add22dcab412)) - -# [0.2.0](https://github.com/guardian/commercial-core/compare/v0.1.1...v0.2.0) (2020-09-22) - - -### Features - -* 🎸 add IAS third-party tag ([71fefbf](https://github.com/guardian/commercial-core/commit/71fefbf87a50f4fff54d6a69e1c50e6f234f669f)) diff --git a/package.json b/package.json index 7d13265c9..0b4e39a4f 100644 --- a/package.json +++ b/package.json @@ -46,8 +46,6 @@ "devDependencies": { "@commitlint/cli": "^11.0.0", "@commitlint/config-conventional": "^11.0.0", - "@semantic-release/changelog": "^5.0.1", - "@semantic-release/git": "^9.0.0", "@semantic-release/github": "^7.1.1", "@types/jest": "^26.0.14", "@typescript-eslint/eslint-plugin": "^4.4.0", diff --git a/yarn.lock b/yarn.lock index 8fdb36693..36afba953 100644 --- a/yarn.lock +++ b/yarn.lock @@ -772,16 +772,6 @@ dependencies: "@types/node" ">= 8" -"@semantic-release/changelog@^5.0.1": - version "5.0.1" - resolved "https://registry.yarnpkg.com/@semantic-release/changelog/-/changelog-5.0.1.tgz#50a84b63e5d391b7debfe021421589fa2bcdafe4" - integrity sha512-unvqHo5jk4dvAf2nZ3aw4imrlwQ2I50eVVvq9D47Qc3R+keNqepx1vDYwkjF8guFXnOYaYcR28yrZWno1hFbiw== - dependencies: - "@semantic-release/error" "^2.1.0" - aggregate-error "^3.0.0" - fs-extra "^9.0.0" - lodash "^4.17.4" - "@semantic-release/commit-analyzer@^8.0.0": version "8.0.1" resolved "https://registry.yarnpkg.com/@semantic-release/commit-analyzer/-/commit-analyzer-8.0.1.tgz#5d2a37cd5a3312da0e3ac05b1ca348bf60b90bca" @@ -795,25 +785,11 @@ lodash "^4.17.4" micromatch "^4.0.2" -"@semantic-release/error@^2.1.0", "@semantic-release/error@^2.2.0": +"@semantic-release/error@^2.2.0": version "2.2.0" resolved "https://registry.yarnpkg.com/@semantic-release/error/-/error-2.2.0.tgz#ee9d5a09c9969eade1ec864776aeda5c5cddbbf0" integrity sha512-9Tj/qn+y2j+sjCI3Jd+qseGtHjOAeg7dU2/lVcqIQ9TV3QDaDXDYXcoOHU+7o2Hwh8L8ymL4gfuO7KxDs3q2zg== -"@semantic-release/git@^9.0.0": - version "9.0.0" - resolved "https://registry.yarnpkg.com/@semantic-release/git/-/git-9.0.0.tgz#304c4883c87d095b1faaae93300f1f1e0466e9a5" - integrity sha512-AZ4Zha5NAPAciIJH3ipzw/WU9qLAn8ENaoVAhD6srRPxTpTzuV3NhNh14rcAo8Paj9dO+5u4rTKcpetOBluYVw== - dependencies: - "@semantic-release/error" "^2.1.0" - aggregate-error "^3.0.0" - debug "^4.0.0" - dir-glob "^3.0.0" - execa "^4.0.0" - lodash "^4.17.4" - micromatch "^4.0.0" - p-reduce "^2.0.0" - "@semantic-release/github@^7.0.0", "@semantic-release/github@^7.1.1": version "7.1.1" resolved "https://registry.yarnpkg.com/@semantic-release/github/-/github-7.1.1.tgz#e998aa9a9cd770838d9f27c64f060c2b686b9d95" @@ -5473,7 +5449,7 @@ micromatch@^3.0.4, micromatch@^3.1.4: snapdragon "^0.8.1" to-regex "^3.0.2" -micromatch@^4.0.0, micromatch@^4.0.2: +micromatch@^4.0.2: version "4.0.2" resolved "https://registry.yarnpkg.com/micromatch/-/micromatch-4.0.2.tgz#4fcb0999bf9fbc2fcbdd212f6d629b9a56c39259" integrity sha512-y7FpHSbMUMoyPbYUSzO6PaZ6FyRnQOpHuKwbo1G+Knck95XVU4QAiKdGEnj5wwoS7PlOgthX/09u5iFJ+aYf5Q==