fix: move vendor back into src #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sndrs
pushed a commit
that referenced
this pull request
Oct 14, 2020
## [0.8.1](v0.8.0...v0.8.1) (2020-10-14) ### Bug Fixes * move vendor back into src ([#57](#57)) ([f27e108](f27e108))
|
🎉 This PR is included in version 0.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
vendorback undersrc, with a__prefix to keep it separate from our own codeWhy?
multiple
rootDirsin the tsconfig meant everything was published under the directory it lives in (src, vendor etc). this broke importing.@ioanna0 and i mulled this over and decided we could either do this or change the main/module paths. that felt wrong, since it's not src at that point, it's our compiled artefact.
also, vendor code is source code of this package, just not ours.
this attempts to mark it as such while keeping a clean published artefact
we should probably add some validation for the built package before publishing it