fix: Create vendor dir and exclude it from coverage #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioanna0
force-pushed
the
iky/exclude-external-cov
branch
from
f58f772 to
0bbd9cd
Compare
sndrs
reviewed
Oct 13, 2020
ioanna0
changed the title
sndrs
approved these changes
Oct 13, 2020
mxdvl
approved these changes
Oct 13, 2020
Comment on lines
+4
to
+5
| export { twitter } from './third-party-tags/twitter-uwt'; | ||
| export { lotame } from './third-party-tags/lotame'; |
There was a problem hiding this comment.
though fix is ok for 2 reasons
- feat was the previous PR here: feat: added twitter pixel & lotame #41 and this is a fix for that
- had to conclude to 1 prefix and fix sounded Ok for the 2 things and didn't want to raise 2 separate PRs. at the end the new release is made
Co-authored-by: Alex Sanders <[email protected]>
sndrs
pushed a commit
that referenced
this pull request
Oct 13, 2020
## [0.7.1](v0.7.0...v0.7.1) (2020-10-13) ### Bug Fixes * Create vendor dir and exclude it from coverage ([#55](#55)) ([85089f8](85089f8))
|
🎉 This PR is included in version 0.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the coverage step in main