feat: Add Event Timer module #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxdvl
approved these changes
Feb 1, 2021
| * @param {origin} [origin=page] - Either 'page' (default) or the name of the slot | ||
| */ | ||
| trigger(eventName: string, origin = 'page'): void { | ||
| const TRACKEDSLOTNAME = 'top-above-nav'; |
There was a problem hiding this comment.
Should this be extracted in a higher scope? It could be used in the triggers on lines 23 and 51.
There was a problem hiding this comment.
Can it be used on line 23?
Co-authored-by: Max Duval <[email protected]>
ashishpuliyel
changed the title
ioanna0
reviewed
Feb 2, 2021
|
Adding the event timer module |
|
🎉 This PR is included in version 0.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
main failed on test coverage step: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds an event timer module that can be imported and used globally.
Why?
As part of the performance OKR we need additional monitoring of performance.
Using this module gives us a single place to collate and handle events recorded for this