fix: Create vendor dir and exclude it from coverage (#55)

* exclude external-scripts from coverage * Refactor vendors & include 3pts to index.ts * Use rootDirs to add vendors * Update tsconfig.build.json Co-authored-by: Alex Sanders <[email protected]> * back to rootDir * bring back rootDirs Co-authored-by: Alex Sanders <[email protected]>
guardian · Oct 13, 2020 · 85089f8 · 85089f8
1 parent 8b6933d
commit 85089f8
Show file tree

Hide file tree

Showing 9 changed files with 11 additions and 7 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,4 @@
 node_modules
 dist
 coverage
+.DS_Store
diff --git a/jest.config.js b/jest.config.js
@@ -27,9 +27,7 @@ module.exports = {
 	// coverageDirectory: undefined,
 
 	// An array of regexp pattern strings used to skip coverage collection
-	// coveragePathIgnorePatterns: [
-	//   "/node_modules/"
-	// ],
+	coveragePathIgnorePatterns: ['vendor'],
 
 	// Indicates which provider should be used to instrument code for coverage
 	// coverageProvider: "babel",

diff --git a/src/index.ts b/src/index.ts
@@ -1,3 +1,5 @@
 export { ias } from './third-party-tags/ias';
 export { permutive } from './third-party-tags/permutive';
 export { fbPixel } from './third-party-tags/facebook-pixel';
+export { twitter } from './third-party-tags/twitter-uwt';
+export { lotame } from './third-party-tags/lotame';
diff --git a/src/third-party-tags/lotame.ts b/src/third-party-tags/lotame.ts
@@ -1,5 +1,5 @@
+import { lotameScript } from '../../vendor/lotame-script';
 import { GetThirdPartyTag } from '../types';
-import { lotameScript } from './external-scripts/lotame-script';
 
 export type LotameData = {
 	ozoneLotameData: Array<string>;

diff --git a/src/third-party-tags/twitter-uwt.spec.ts b/src/third-party-tags/twitter-uwt.spec.ts
@@ -1,4 +1,4 @@
-import { twitterScript } from './external-scripts/twitter-script';
+import { twitterScript } from '../../vendor/twitter-script';
 import { twitter } from './twitter-uwt';
 
 describe('twitter', () => {

diff --git a/src/third-party-tags/twitter-uwt.ts b/src/third-party-tags/twitter-uwt.ts
@@ -1,5 +1,5 @@
+import { twitterScript as insertSnippet } from '../../vendor/twitter-script';
 import { GetThirdPartyTag } from '../types';
-import { twitterScript as insertSnippet } from './external-scripts/twitter-script';
 
 export const twitter: GetThirdPartyTag = ({ shouldRun }) => ({
 	shouldRun,

diff --git a/tsconfig.build.json b/tsconfig.build.json
@@ -3,7 +3,10 @@
 		"declaration": true,
 		"noEmit": false,
 		"outDir": "dist",
-		"rootDir": "src"
+		"rootDirs": [
+			"../../vendor",
+			"src",
+		  ]
 	},
 	"extends": "./tsconfig.json",
 	"include": ["src"],

diff --git a/...ty-tags/external-scripts/lotame-script.ts → vendor/lotame-script.ts b/...ty-tags/external-scripts/lotame-script.ts → vendor/lotame-script.ts
diff --git a/...y-tags/external-scripts/twitter-script.ts → vendor/twitter-script.ts b/...y-tags/external-scripts/twitter-script.ts → vendor/twitter-script.ts