From 51168c7be9d0e5413eb10218bf12864cb791e508 Mon Sep 17 00:00:00 2001 From: Jacob Winch Date: Wed, 7 Apr 2021 16:47:47 +0100 Subject: [PATCH] fix: use traffic port for ALB healthcheck by default --- src/constructs/loadbalancing/alb.test.ts | 2 +- src/constructs/loadbalancing/alb.ts | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/constructs/loadbalancing/alb.test.ts b/src/constructs/loadbalancing/alb.test.ts index 4eec794f98..ab5faf2590 100644 --- a/src/constructs/loadbalancing/alb.test.ts +++ b/src/constructs/loadbalancing/alb.test.ts @@ -124,7 +124,6 @@ describe("The GuApplicationTargetGroup class", () => { expect(stack).toHaveResource("AWS::ElasticLoadBalancingV2::TargetGroup", { HealthCheckIntervalSeconds: 30, HealthCheckPath: "/healthcheck", - HealthCheckPort: "9000", HealthCheckProtocol: "HTTP", HealthCheckTimeoutSeconds: 10, HealthyThresholdCount: 2, @@ -138,6 +137,7 @@ describe("The GuApplicationTargetGroup class", () => { vpc, healthCheck: { path: "/test", + port: "9000", }, }); diff --git a/src/constructs/loadbalancing/alb.ts b/src/constructs/loadbalancing/alb.ts index e4e2ecc6e3..f479f0ff28 100644 --- a/src/constructs/loadbalancing/alb.ts +++ b/src/constructs/loadbalancing/alb.ts @@ -43,7 +43,6 @@ export interface GuApplicationTargetGroupProps extends ApplicationTargetGroupPro export class GuApplicationTargetGroup extends ApplicationTargetGroup { static DefaultHealthCheck = { - port: "9000", path: "/healthcheck", protocol: Protocol.HTTP, healthyThresholdCount: 2,