fix: use traffic port for ALB healthcheck by default #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akash1810
approved these changes
Apr 7, 2021
|
🎉 This PR is included in version 7.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This simplifies the default healthcheck for ALBs by defaulting to using the traffic port, rather than defaulting to a commonly used (but hardcoded) value.
Does this change require changes to existing projects or CDK CLI?
I think it's very unlikely that any existing projects will be affected by this change.*
How to test
I think the updated unit tests are sufficient?
How can we measure success?
When defining the EC2 App pattern, we'll no longer need to override this default when a different traffic/application port is specified.
Have we considered potential risks?
*There is a small risk that a project is currently relying on this default to perform a healthcheck via port 9000 even though they are sending all other traffic to a different port. This strikes me as extremely unlikely, particularly given the low adoption levels for this project at this stage!