-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Value trait impls for ValueArray #28
Comments
See https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/issues/274 for use-case |
Actually it implements the trait but it's hidden from the docs. @GuillaumeGomez can we not hide these trait impls that users would use? :) Nonetheless there's the mutability problem I mentioned above. |
Why would they be hidden? |
I'm fine with removing the |
Only for the ones that are relevant for non-FFI usage. I would keep them for all the From/To pointer traits. |
Then sounds good to me. |
Ok, well in addition we have to fix the soundness issue related to |
Mean problem here is that it allows circumventing the exclusivity of
&mut
references as it is actually reference counted inGValue
s. Needs some thinking!The text was updated successfully, but these errors were encountered: