Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Value trait impls for ValueArray #28

Closed
Tracked by #137
sdroege opened this issue Jul 8, 2020 · 8 comments
Closed
Tracked by #137

Add Value trait impls for ValueArray #28

sdroege opened this issue Jul 8, 2020 · 8 comments

Comments

@sdroege
Copy link
Member

sdroege commented Jul 8, 2020

Mean problem here is that it allows circumventing the exclusivity of &mut references as it is actually reference counted in GValues. Needs some thinking!

@sdroege
Copy link
Member Author

sdroege commented Jul 8, 2020

@sdroege
Copy link
Member Author

sdroege commented Jul 9, 2020

Actually it implements the trait but it's hidden from the docs. @GuillaumeGomez can we not hide these trait impls that users would use? :)

Nonetheless there's the mutability problem I mentioned above.

@GuillaumeGomez
Copy link
Member

Why would they be hidden?

@sdroege
Copy link
Member Author

sdroege commented Jul 9, 2020

@GuillaumeGomez
Copy link
Member

I'm fine with removing the #[doc(hidden)]. Do you plan to remove these from all traits?

@sdroege
Copy link
Member Author

sdroege commented Jul 9, 2020

Only for the ones that are relevant for non-FFI usage. I would keep them for all the From/To pointer traits.

@GuillaumeGomez
Copy link
Member

Then sounds good to me.

@sdroege
Copy link
Member Author

sdroege commented Jul 9, 2020

Ok, well in addition we have to fix the soundness issue related to ValueArray specifically :)

@sdroege sdroege transferred this issue from gtk-rs/glib Nov 9, 2020
@GuillaumeGomez GuillaumeGomez transferred this issue from gtk-rs/gtk3-rs May 14, 2021
@sdroege sdroege closed this as completed May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants