Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new_from_XXX() / new_with_XXX() functions are not renamed in the docs #936

Closed
Tracked by #137
sdroege opened this issue Jun 21, 2020 · 7 comments · Fixed by #1098
Closed
Tracked by #137

new_from_XXX() / new_with_XXX() functions are not renamed in the docs #936

sdroege opened this issue Jun 21, 2020 · 7 comments · Fixed by #1098

Comments

@sdroege
Copy link
Member

sdroege commented Jun 21, 2020

Since #929 they are renamed to not have the new prefix anymore, but the renaming did not happen for the docs.

Should be fixed before the release :)

See https://gstreamer.pages.freedesktop.org/gstreamer-rs/gstreamer/struct.Pad.html#method.from_template for an example that has no docs anymore.

CC @EPashkin @GuillaumeGomez @gdesmott

@gdesmott
Copy link

IIRC my patch should use the same code paths as when user manually rename a function using the toml file. Was doc broken for those as well?

@sdroege
Copy link
Member Author

sdroege commented Jun 22, 2020

I don't know, there are some normal renames in gtk and gio IIRC that you could use for testing

@gdesmott
Copy link

That's strange, DBusInterfaceExt.get() and WidgetExt.set_widget_name() both use rename. The former is not documented (but neither are the other functions in this trait) but the former is.

@sdroege
Copy link
Member Author

sdroege commented Jun 22, 2020

Something for @GuillaumeGomez I guess :)

@GuillaumeGomez
Copy link
Member

To be checked...

@sdroege
Copy link
Member Author

sdroege commented Jan 30, 2021

@GuillaumeGomez You fixed this or not?

@bilelmoussaoui
Copy link
Member

cc @fengalin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants