-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use glib::Closure for signal connector functions #474
Comments
I implemented something like this here manually for a signal: sdroege/gstreamer-rs@b58f4cd The cast for the first argument could be improved to not require all the runtime checks, otherwise we just need to change gir to emit code like this |
Any comments on this, should we generate code like this (or how should it be different?) instead of all the unsafe trampoline magic? |
@EPashkin What do you think? Would you be interested in working on this, it seems like all the trampoline code is yours so it's probably fastest if you look into this. I expect a lot of code (also generally in the code generator) to be possible to remove after this, it could be a major cleanup of gir. |
@sdroege It interesting, but I prefer postpone this until next release. |
After a discussion with @sdroege, he gave me a few extra information that might be useful to solve this issue: We want to use We also need to add some more |
No need to use unsafe trampolines anymore.
The text was updated successfully, but these errors were encountered: