Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password, username and URL is saved in plain text #25

Closed
charroch opened this issue Feb 19, 2013 · 9 comments
Closed

Password, username and URL is saved in plain text #25

charroch opened this issue Feb 19, 2013 · 9 comments

Comments

@charroch
Copy link

The password especially. This is a security threat, especially given that it saves it within the project tree and usually within VC.

@gshakhn
Copy link
Owner

gshakhn commented Feb 19, 2013

Do you have any recommendations on how else to save the password? AFAIK, we need the raw password in order to authenticate with sonar web services.

http://docs.codehaus.org/display/SONAR/Web+Service+API

@aheusingfeld
Copy link
Collaborator

We could try to use the build-in authentication / password-manager of IDEA. This is also used for e.g. authentication at github or password protected private-key authentications. If this is ok for everyone, I'll try to find a sample how to use this.

@charroch
Copy link
Author

@aheusingfeld
Copy link
Collaborator

I found a sample showing a possible implementation here: https://github.com/JetBrains/intellij-community/blob/master/plugins/git4idea/src/git4idea/jgit/GitHttpAdapter.java

Unfortunately the build of "sonar-intellij-plugin" fails on my local machine due to a problem with "ideauidesigner-maven-plugin" therefore I am currently not able fix the problem. @gshakhn can you provide the fix?

@gshakhn
Copy link
Owner

gshakhn commented Feb 19, 2013

@aheusingfeld You'll have to install https://github.com/gshakhn/ideauidesigner-maven-plugin locally. The official version of the maven plugin doesn't work with 12.x due to a weird compiler issue.

@aheusingfeld
Copy link
Collaborator

Has anyone started on this one, yet? Otherwise I'm going to take on it next week.

@gshakhn
Copy link
Owner

gshakhn commented Mar 10, 2013

Haven't started this yet, so go for it. :)

@aheusingfeld
Copy link
Collaborator

I already started but it's a little more tricky than I thought. I'm currently thinking about how to remove the password from the existing config files without messing our code. Seems I need a little more reading on the @State and @Storage annotations' implicit behaviour. ;)

@aheusingfeld
Copy link
Collaborator

I moved this issue to the new home of our plugin at sonar-intellij-plugin/sonar-intellij-plugin#18. Please comment there for further issues. Thanks for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants