Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File creator no longer remembers the previous file extension #2332

Closed
4 tasks done
wshoy opened this issue Jun 22, 2024 · 5 comments · Fixed by #2307
Closed
4 tasks done

File creator no longer remembers the previous file extension #2332

wshoy opened this issue Jun 22, 2024 · 5 comments · Fixed by #2307
Assignees
Labels
Milestone

Comments

@wshoy
Copy link
Contributor

wshoy commented Jun 22, 2024

⚠️ This issue respects the following points: ⚠️

  • This is a bug. Not a question or feature request.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)

Description

It was not explicitly stated, but the file creator used to remember the previous file extension (version 2.12.0).
It was useful for creating multiple files of type other than in the type dropdown.
I think the feature should be brought back or maybe even a "Previous" type option could be added.

Steps to reproduce

  1. Tap the "+" button
  2. Create a file "aaa" with an ".html" extension
  3. Tap the "+" button again
  4. The ".html" extension is replaced with the one in the type dropdown

Information

Android version: 13
Device:
App Version: 2.12.2

Source

F-Droid

Format / File type

Not specific

Additional info / Log

-
@harshad1
Copy link
Collaborator

What is the desired behavior here?

@wshoy
Copy link
Contributor Author

wshoy commented Jun 25, 2024

What is the desired behavior here?

In 2.12.0 if one created a file aaa.html and attempted to create another, the name field was empty and the extension remained ".html". That should be the correct behavior. In the next versions, to create multiple .html files for example, one needs to write the name AND replace the extension .md with .html on every file creation (if the type option is set to "Markdown").

@wshoy
Copy link
Contributor Author

wshoy commented Jun 25, 2024

the name field was empty and the extension remained ".html". That should be the correct behavior.

@harshad1 I have realized I didn't quite respond to your question before. This is the edit.

@harshad1
Copy link
Collaborator

Ok. Seems reasonable. I'll add that functionality back

@harshad1
Copy link
Collaborator

harshad1 commented Jul 5, 2024

Added in #2037

@gsantner gsantner linked a pull request Jul 20, 2024 that will close this issue
@gsantner gsantner added the bug label Jul 20, 2024
@gsantner gsantner added this to the Markor v2.13 milestone Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants