Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash after creating files with certain extensions #2329

Closed
4 tasks done
wshoy opened this issue Jun 17, 2024 · 4 comments · Fixed by #2307
Closed
4 tasks done

Crash after creating files with certain extensions #2329

wshoy opened this issue Jun 17, 2024 · 4 comments · Fixed by #2307
Assignees
Labels
Milestone

Comments

@wshoy
Copy link
Contributor

wshoy commented Jun 17, 2024

⚠️ This issue respects the following points: ⚠️

  • This is a bug. Not a question or feature request.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)

Description

Making an .xz or .xyz file causes the app to crash.

Steps to reproduce

  1. Create a file with .xz or .xyz extension

Information

Android version: 13
Device:
App Version: 2.12.2

Source

F-Droid

Format / File type

Not specific

Additional info / Log

-
@gsantner
Copy link
Owner

gsantner commented Jun 17, 2024

Not crashes here. However if you create files which are commonly binary file extensions you can assume that something won't work.

Attach logcat log file please.

@wshoy
Copy link
Contributor Author

wshoy commented Jun 18, 2024

Ok, it's opening binary files that's causing it. It's not like anyone would do that, but I don't think it should crash.

@harshad1
Copy link
Collaborator

Can reproduce. Will fix.

I should have realized as I work with point clouds for my day job :)

@harshad1
Copy link
Collaborator

I have a solution pushed in #2307.

@gsantner gsantner linked a pull request Jul 20, 2024 that will close this issue
@gsantner gsantner added the bug label Jul 20, 2024
@gsantner gsantner added this to the Markor v2.13 milestone Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants