Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc errata in current PDF snapshot #349

Open
sgpinkus opened this issue Nov 7, 2021 · 2 comments
Open

Misc errata in current PDF snapshot #349

sgpinkus opened this issue Nov 7, 2021 · 2 comments

Comments

@sgpinkus
Copy link
Contributor

sgpinkus commented Nov 7, 2021

I don't know how the PDF at https://www.gs1.org/standards/development-work-groups/public-reviews#EPCISCBV_Public-Review-2021 gets built or if these errors have been corrected already, but I noticed a couple:

  • p49 "Resoruce" should be "Resource".
  • p54 "The LocationID type is a supertype of ReadPointID, BusinessStepID, and SourceDestID". Pretty sure BusinessStepID is supposed to be "BusinessLocationID".
@mgh128
Copy link
Collaborator

mgh128 commented Nov 8, 2021

Thanks - I have noted the typo for Resoruce, together with approximately 80 further typos which are easy to fix. ( Personally I prefer the earlier process in which there was a thorough work group review before community review - but I don't set the timelines ).
I think you're probably correct that ReadPointID, BusinessLocationID (but not BusinessStepID) are subclasses of LocationID. SourceDestID can also be a subclass of LocationID but can sometimes by a subclass of OrganizationID (when indicating a source/destination organization in a chain of custody or ownership, rather than a source/destination location). I'll check that this feedback is included in our combined spreadsheet of review comments and acted upon.

@VladimirAlexiev
Copy link
Contributor

Please note that SourceOrDestination is a class with two fields:
image

  • one is Place or Organization
  • the other is type (SDT)

That imho is another reason why it cannot be a subtype of an ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants