Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect secretsmanager resource type config file key #713

Closed
sbocinec opened this issue May 29, 2024 · 0 comments · Fixed by #714
Closed

Incorrect secretsmanager resource type config file key #713

sbocinec opened this issue May 29, 2024 · 0 comments · Fixed by #714

Comments

@sbocinec
Copy link
Contributor

sbocinec commented May 29, 2024 •
edited
Loading

There is a typo in the What's supported section of the README incorrectly specifying SecretsManagerSecrets as the config key for secretsmanager resource type.

I spent an hour troubleshooting why the secretsmanager cloud-nuke config exclusions are ignored, to find, the correct config key for secretsmanager is SecretsManager.

Ref:

cloud-nuke/config/config.go

Line 95 in ed8da6a

SecretsManagerSecrets ResourceType `yaml:"SecretsManager"`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix secretsmanager config file key name in README sbocinec/cloud-nuke
1 participant
@sbocinec