Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we simplify making AWS API calls with paging? #226

Closed
ina-stoyanova opened this issue Oct 29, 2021 · 1 comment
Closed

Could we simplify making AWS API calls with paging? #226

ina-stoyanova opened this issue Oct 29, 2021 · 1 comment
Labels
maintainer only We need a Grunt to take the lead on this issue needs design We need to flesh out the design before we can resolve the issue

Comments

@ina-stoyanova
Copy link
Contributor

Context:
In quite a few of our aws functions we have to make a batched call into AWS API to get some data (E.g. s3 module & dynamodb, and others).

Question: Is it possible to extract this logic somehow? E.g. so not every module has to figure out how to paging and batch calls on its own?

@ina-stoyanova ina-stoyanova added question needs design We need to flesh out the design before we can resolve the issue maintainer only We need a Grunt to take the lead on this issue labels Oct 29, 2021
@james03160927
Copy link
Contributor

For any future resources we implement, we can leverage the pages get calls to handle pagination, instead of having our own batching logic. A lot of the resources already use this API for that.

Closing this issue since this is no longer relevant - may not make sense to make this change to all existing resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer only We need a Grunt to take the lead on this issue needs design We need to flesh out the design before we can resolve the issue
Projects
None yet
Development

No branches or pull requests

3 participants