Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update the table of contents #161

Merged
merged 2 commits into from
Feb 12, 2024
Merged

docs: update the table of contents #161

merged 2 commits into from
Feb 12, 2024

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Feb 9, 2024 •
edited
Loading

Description

Fixes #160.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@suzuki-shunsuke suzuki-shunsuke marked this pull request as ready for review February 9, 2024 22:16
@suzuki-shunsuke suzuki-shunsuke mentioned this pull request Feb 9, 2024
Closed
@suzuki-shunsuke suzuki-shunsuke marked this pull request as draft February 9, 2024 22:17
@suzuki-shunsuke suzuki-shunsuke changed the title docs: revert the unexpected update of the list [WIP] docs: revert the unexpected update of the list Feb 9, 2024
@suzuki-shunsuke
Copy link
Contributor Author

I found the list is broken.
I'll fix.

@suzuki-shunsuke suzuki-shunsuke changed the title [WIP] docs: revert the unexpected update of the list docs: revert the unexpected update of the list Feb 9, 2024
@suzuki-shunsuke suzuki-shunsuke marked this pull request as ready for review February 9, 2024 22:23
@suzuki-shunsuke suzuki-shunsuke changed the title docs: revert the unexpected update of the list docs: update the table of contents Feb 9, 2024
@suzuki-shunsuke
Copy link
Contributor Author

I found the list is broken. I'll fix.

Done. fa96767

brikis98
brikis98 approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@brikis98 brikis98 merged commit 7070400 into gruntwork-io:master Feb 12, 2024
2 checks passed
@suzuki-shunsuke suzuki-shunsuke deleted the docs/revert-unexpected-list-update branch February 12, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brikis98 brikis98 brikis98 approved these changes

@james03160927 james03160927 Awaiting requested review from james03160927

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: The list was updated unexpectedly by VSCode extension
2 participants
@suzuki-shunsuke @brikis98