Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gruntfile should not be case sensitive #685

Closed
steida opened this issue Feb 21, 2013 · 6 comments
Closed

gruntfile should not be case sensitive #685

steida opened this issue Feb 21, 2013 · 6 comments

Comments

@steida
Copy link

steida commented Feb 21, 2013

If Gruntfile.coffee is defined as gruntfile.coffee, grunt will not find it. Finding should be case insensitive.

@meaku
Copy link

meaku commented Feb 21, 2013

+1 on this one... this took me quite some time to figure out what's wrong.

@cowboy
Copy link
Member

cowboy commented Feb 21, 2013

I agree! However, this appears to be a bug in the underlying node-glob library.

I filed an issue at isaacs/node-glob#59.

@meaku
Copy link

meaku commented Feb 21, 2013

Ok! Then sorry for blaming grunt :)

@cowboy cowboy closed this as completed in 6fe639f Mar 12, 2013
@cowboy
Copy link
Member

cowboy commented Mar 12, 2013

@meaku is it possible for you to test this? I want to make sure it works. If you're unsure how to do this, check out the Installing directly from github guide. The commit-ish will be 6fe639fff7e9c37801ae755fb88bb1285e8afec7.

Thanks!

@kevva
Copy link
Member

kevva commented Mar 13, 2013

Works for me. Tested with gRuNtFiLe.js and gRuNtFiLe.coffee 🍰.

@meaku
Copy link

meaku commented Mar 13, 2013

Thanks @cowboy! Works for me as well!

jrolfs added a commit to jrolfs/grunt that referenced this issue Mar 16, 2013
* master:
  quote version number for travis
  add node 0.10 to travis
  Bumping version to 0.4.1 and publishing to npm.
  Fix path.join thrown errors with expandMapping rename. Closes gruntjsgh-725.
  Update copyright date to 2013. Closes gruntjsgh-660.
  Remove some side effects from manually requiring Grunt. Closes gruntjsgh-605.
  grunt.log: add formatting support and implicitly cast msg to a string. Closes gruntjsgh-703.
  Update js-yaml to version 2. Closes gruntjsgh-683.
  The grunt.util.spawn method now falls back to stdout when the `grunt` option is set. Closes gruntjsgh-691.
  Making --verbose "Files:" warnings less scary. Closes gruntjsgh-657.
  Fixing typo: the grunt.fatal method now defaults to FATAL_ERROR. Closes gruntjsgh-656, gruntjsgh-707.
  Removed a duplicate line. Closes gruntjsgh-702.
  Gruntfile name should no longer be case sensitive. Closes gruntjsgh-685.
  The grunt.file.delete method warns and returns false if file doesn't exist. Closes gruntjsgh-635, gruntjsgh-714.
  The grunt.package property is now resolved via require(). Closes gruntjsgh-704.
  The grunt.util.spawn method no longer breaks on multibyte stdio. Closes gruntjsgh-710.
  Fix "path.join arguments must be strings" error in file.expand/recurse when options.cwd is not set. Closes gruntjsgh-722.
  Adding a fairly relevant keyword to package.json.
  Bumping version for development.
theasta added a commit to theasta/grunt that referenced this issue Apr 20, 2013
* upstream/master: (21 commits)
  Add grunt logo to readme
  npmignore unneeded files
  quote version number for travis
  add node 0.10 to travis
  Bumping version to 0.4.1 and publishing to npm.
  Fix path.join thrown errors with expandMapping rename. Closes gruntjsgh-725.
  Update copyright date to 2013. Closes gruntjsgh-660.
  Remove some side effects from manually requiring Grunt. Closes gruntjsgh-605.
  grunt.log: add formatting support and implicitly cast msg to a string. Closes gruntjsgh-703.
  Update js-yaml to version 2. Closes gruntjsgh-683.
  The grunt.util.spawn method now falls back to stdout when the `grunt` option is set. Closes gruntjsgh-691.
  Making --verbose "Files:" warnings less scary. Closes gruntjsgh-657.
  Fixing typo: the grunt.fatal method now defaults to FATAL_ERROR. Closes gruntjsgh-656, gruntjsgh-707.
  Removed a duplicate line. Closes gruntjsgh-702.
  Gruntfile name should no longer be case sensitive. Closes gruntjsgh-685.
  The grunt.file.delete method warns and returns false if file doesn't exist. Closes gruntjsgh-635, gruntjsgh-714.
  The grunt.package property is now resolved via require(). Closes gruntjsgh-704.
  The grunt.util.spawn method no longer breaks on multibyte stdio. Closes gruntjsgh-710.
  Fix "path.join arguments must be strings" error in file.expand/recurse when options.cwd is not set. Closes gruntjsgh-722.
  Adding a fairly relevant keyword to package.json.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants