-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformat output. #162
Comments
+1 |
+1 Seeing them side to side now, I like the color better and the highlighted error instead of the ^. |
+1 |
Does anyone want to take a stab at changing the visual style? @shama? @vladikoff? |
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is what I see now:
Compare that to >=0.8.0:
While I like the line number on the left and the reduction of colors in general, I don't really like the indentation of the
^ message
because it's going to wrap oddly in many circumstances.First, I'd remove the per-file indentation, and would intelligently compute the width of the "line number" column per-file using the grunt.log.table method, like so:
Maybe after that, I'd go back to visually highlighting the invalid character and not indenting the warning message, simulated here with
[]
.Basically, I'd like to see a hybrid between the old and the new way, because I don't think the new way is a clear-cut improvement.
The text was updated successfully, but these errors were encountered: