-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix depset issues with/upgrade to Bazel 0.27.1 #578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Having rules break because of --incompatible_*
changes is always a bit annoying.
LGTM w/ nit
Done! |
Thank you. Can we have a merge of this soon? |
Apparently, when executing this is the error message:
Could be an environment issue. |
Is Kokoro using Ubuntu 14.04? Bazel started building its releases on 16.04 starting with 0.27.0 which could cause issues like that. |
Yep, sounds like Ubuntu 14.04 is the issue. Is there anything I can do? |
There was some discussion here: bazelbuild/bazel#7816 (comment) and it seems the next release should support Ubuntu 14.04 again. |
@factuno-db Can we upgrade to / test with Bazel 0.27.1? |
Sure, I've checked daily for new Bazel releases ;-) |
Yay tests passed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
This PR updates rules_closures and Bazel.
depset
is no longer iterable starting from Bazel 0.27.0.