Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depset issues with/upgrade to Bazel 0.27.1 #578

Merged
merged 5 commits into from
Jul 2, 2019

Conversation

danfabi
Copy link
Contributor

@danfabi danfabi commented Jun 22, 2019

This PR updates rules_closures and Bazel.

depset is no longer iterable starting from Bazel 0.27.0.

Yannic
Yannic previously approved these changes Jun 22, 2019
Copy link
Contributor

@Yannic Yannic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Having rules break because of --incompatible_* changes is always a bit annoying.

LGTM w/ nit

bazel/closure_grpc_web_library.bzl Outdated Show resolved Hide resolved
@danfabi
Copy link
Contributor Author

danfabi commented Jun 22, 2019

Done!

Yannic
Yannic previously approved these changes Jun 22, 2019
@nghialv
Copy link
Contributor

nghialv commented Jun 24, 2019

Thank you. Can we have a merge of this soon?

@stanley-cheung
Copy link
Collaborator

Apparently, when executing ./bazel-0.27.0-installer-linux-x86_64.sh --user,

this is the error message:

## Build information
   - [Commit](https://github.com/bazelbuild/bazel/commit/c82eb48)
Uncompressing....../home/kbuilder/bin/bazel: relocation error: /home/kbuilder/bin/bazel: symbol _ZTVNSt7__cxx1115basic_stringbufIcSt11char_traitsIcESaIcEEE, version GLIBCXX_3.4.21 not defined in file libstdc++.so.6 with link time reference


[ID: 5297890] Build finished after 815 secs, exit value: 127

Could be an environment issue.

@Yannic
Copy link
Contributor

Yannic commented Jun 24, 2019

Is Kokoro using Ubuntu 14.04? Bazel started building its releases on 16.04 starting with 0.27.0 which could cause issues like that.
https://blog.bazel.build/2019/06/17/bazel-0.27.0.html

@danfabi
Copy link
Contributor Author

danfabi commented Jun 25, 2019

Yep, sounds like Ubuntu 14.04 is the issue. Is there anything I can do?

@Globegitter
Copy link
Contributor

There was some discussion here: bazelbuild/bazel#7816 (comment) and it seems the next release should support Ubuntu 14.04 again.

@Yannic
Copy link
Contributor

Yannic commented Jul 2, 2019

@factuno-db Can we upgrade to / test with Bazel 0.27.1?

@danfabi
Copy link
Contributor Author

danfabi commented Jul 2, 2019

Sure, I've checked daily for new Bazel releases ;-)

@stanley-cheung
Copy link
Collaborator

Yay tests passed :)

Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@stanley-cheung stanley-cheung merged commit a3174cb into grpc:master Jul 2, 2019
@stanley-cheung stanley-cheung changed the title Fix depset issues with/upgrade to Bazel 0.27.0 Fix depset issues with/upgrade to Bazel 0.27.1 Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants