New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove now-incorrect assertion in completion queue wrapper #92

Merged

murgatroid99 merged 1 commit into grpc:v1.7.x from murgatroid99:completion_queue_assertion_fix

Nov 17, 2017

Member

murgatroid99 commented Nov 16, 2017 •

edited

Loading

After adding the CompletionQueueForcePoll method to make waitForReady work properly, this assertion is no longer correct.

This fixes #91.


          Remove now-incorrect assertion in completion queue wrapper

45a3ac2

murgatroid99 requested review from kjin and nicolasnoble

November 16, 2017 18:01

nicolasnoble approved these changes

View reviewed changes

murgatroid99 merged commit 1ecab67 into grpc:v1.7.x

lock bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet