Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make grpc-js not wait for ready by default #896

Closed
murgatroid99 opened this issue May 31, 2019 · 3 comments
Closed

Make grpc-js not wait for ready by default #896

murgatroid99 opened this issue May 31, 2019 · 3 comments
Assignees

Comments

@murgatroid99
Copy link
Member

The default core behavior is to end a stream with a non-OK status (usually UNAVAILABLE) as soon as the channel enters the TRANSIENT_FAILURE state, with an option wait_for_ready to keep waiting instead. The grpc-js library currently always behaves as though the wait_for_ready option is set. That should be changed to align the behavior with the C core.

@LINKIWI
Copy link

LINKIWI commented Jul 20, 2019

Hi @murgatroid99, curious if there has been any progress on this bug. This bug prevents fail-fast behavior in my client, which is necessary for my use case. I'm happy to contribute if the fix is accessible to someone new to gRPC internals.

@murgatroid99
Copy link
Member Author

I'm working on it but it's taking some time. I'm fixing this as part of a larger overhaul of how channel connectivity is handled.

@murgatroid99
Copy link
Member Author

This has been fixed as of 0.6.x.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants