Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min Java SDK at 1.7 or 1.8? #191

Closed
chalin opened this issue Oct 20, 2020 · 2 comments · Fixed by #192
Closed

Min Java SDK at 1.7 or 1.8? #191

chalin opened this issue Oct 20, 2020 · 2 comments · Fixed by #192
Assignees
Labels
question Further information is requested

Comments

@chalin
Copy link
Contributor

chalin commented Oct 20, 2020

We follow gRPC Java in requiring JDK 7+, as specified in the Quick start, for example:

I've noticed that in some of the examples/stub*/build.gradle.kts files, the sourceCompatibility is set to 1.8; for example:

sourceCompatibility = JavaVersion.VERSION_1_8

My questions:

  • Should this be 1.7?
  • Why isn't the same setting used in stub-android/build.gradle.kts?

cc @bshaffer

@chalin chalin added the question Further information is requested label Oct 20, 2020
@jamesward
Copy link
Collaborator

I used JDK 8 in the samples so that we can use kotlin("stdlib-jdk8") but we probably aren't taking advantage of anything in there so we can see about just using kotlin("stdlib") which I think is JDK 7 compatible.

We aren't really using the Java stuff in the Android sample which is why we don't need to set java settings.

@chalin
Copy link
Contributor Author

chalin commented Oct 20, 2020

Thanks for the explanation. @jamesward, can you make this change in the example config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants