Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable previously disabled aarch64 tests #8127

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

jtattermusch
Copy link
Contributor

@jtattermusch jtattermusch commented Apr 29, 2021

Based on #8126 (only the last commit is the actual change).

My experiments show that after upgrading netty-tcnative-boringssl-static, the tests are reasonably stable (i got a few consecutive passing runs).

@jtattermusch
Copy link
Contributor Author

@ejona86

@ejona86
Copy link
Member

ejona86 commented Apr 29, 2021

There's more to the tcnative upgrade process than this. In particular right now, tcnative 2.0.35 is incompatible with static JNI builds as used internally because it swapped to netty-jni-util which was incompatible for a while: netty/netty-jni-util#5. @dapengzhang0 was going to be upgrading Netty this quarter, which entails dealing with the new netty-jni-util stuff and jumping over the incompatible versions.

@jtattermusch
Copy link
Contributor Author

Fair enough, thanks for the clarification.
I removed the netty-tcnative-boringssl-static upgrade part and only left the part that reenables the tests.
They can be re-enabled once netty-tcnative-boringssl-static is upgraded.

@dapengzhang0 do you have an ETA for the netty-tcnative-boringssl-static upgrade?

@ejona86
Copy link
Member

ejona86 commented Sep 21, 2021

#8167 bumped the version of Netty. So this may be ready.

@jtattermusch
Copy link
Contributor Author

I rebased and started an adhoc run

@jtattermusch
Copy link
Contributor Author

@ejona86 the adhoc run is green, so this PR should be safe to merge.

@ejona86 ejona86 merged commit 3049c2c into grpc:master Sep 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants