Fix retry race condition (1.63.x backport) #11033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tSubStreams and so miss calling closed (grpc#11026)
YifeiZhuang
approved these changes
Mar 22, 2024
larry-safran
added
kokoro:run
grpc-kokoro
removed
the
kokoro:force-run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future.cancel can return true when the executable has started, but the future value hasn't yet been set which was causing us to do an extra decrement. That is what was causing
DriveSimControllerRuleTestto fail with the first attempt to fix the retry deadlock.Backport of #11026