Have EDS resource parse the additional addresses from envoy message #11011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YifeiZhuang
approved these changes
Mar 13, 2024
YifeiZhuang
reviewed
Mar 13, 2024
| endpoints.add(Endpoints.LbEndpoint.create( | ||
| new EquivalentAddressGroup(ImmutableList.<java.net.SocketAddress>of(addr)), | ||
| new EquivalentAddressGroup(addresses), |
There was a problem hiding this comment.
ImmutableList.copyOf()?
There was a problem hiding this comment.
Addresses is already a new list (created on line 196), so we don't care what is done with it. On top of that the EquivalentAddressGroup constructor copies whatever we give it.
this.addrs = Collections.unmodifiableList(new ArrayList<>(addrs));
|
This should be flag protected behind |
…of envoy_api to match core.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.