Fix outbound message size checking #10739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two bugs in outbound message size checking: * When thet checke failed, the thrown StatusRuntimeException with a status code of RESOURCE_EXHAUSTED was been caught and rewrapped in another StatusRuntimeException but this time with status code UNKNOWN. * This applies the max outbound message size check to messages prior to, and after compression, since compression of a message that is smaller than the maximum send size can result in a larger message that exceeds the maximum send size.
It should have been INTERNAL and the original exception in We really don't care that much about this level of precision of the outbound maximum message size, but that just means we wouldn't spend much effort on it. This is a very clean change, so easy to accept. |
ejona86
approved these changes
Dec 13, 2023
|
This fixes #10738 |
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two bugs in outbound message size checking:
StatusRuntimeExceptionwith a status code ofRESOURCE_EXHAUSTEDwas being caught and rewrapped in anotherStatusRuntimeExceptionbut this time with a status code ofUNKNOWN, and the error message was lost.Closes #10738.