servlet: Check log fine level before hex string conversion. Fixes #11031

.
grpc · Mar 25, 2024 · f7ee5f3 · f7ee5f3
1 parent 537dbe8
commit f7ee5f3
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java b/servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java
@@ -32,6 +32,7 @@
 import java.util.concurrent.locks.LockSupport;
 import java.util.function.BiFunction;
 import java.util.function.BooleanSupplier;
+import java.util.logging.Level;
 import java.util.logging.Logger;
 import javax.annotation.CheckReturnValue;
 import javax.annotation.Nullable;
@@ -86,6 +87,11 @@ final class AsyncServletOutputStreamWriter {
       InternalLogId logId) throws IOException {
     Logger logger = Logger.getLogger(AsyncServletOutputStreamWriter.class.getName());
     this.log = new Log() {
+      @Override
+      public boolean isLoggable(Level level) {
+        return logger.isLoggable(level);
+      }
+
       @Override
       public void fine(String str, Object... params) {
         if (logger.isLoggable(FINE)) {
@@ -105,7 +111,9 @@ public void finest(String str, Object... params) {
     this.writeAction = (byte[] bytes, Integer numBytes) -> () -> {
       outputStream.write(bytes, 0, numBytes);
       transportState.runOnTransportThread(() -> transportState.onSentBytes(numBytes));
-      log.finest("outbound data: length={0}, bytes={1}", numBytes, toHexString(bytes, numBytes));
+      if (log.isLoggable(Level.FINEST)) {
+        log.finest("outbound data: length={0}, bytes={1}", numBytes, toHexString(bytes, numBytes));
+      }
     };
     this.flushAction = () -> {
       log.finest("flushBuffer");
@@ -245,6 +253,10 @@ interface ActionItem {
 
   @VisibleForTesting // Lincheck test can not run with java.util.logging dependency.
   interface Log {
+    default boolean isLoggable(Level level) {
+      return false; 
+    }
+
     default void fine(String str, Object...params) {}
 
     default void finest(String str, Object...params) {}