Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response is not compressed when grpc-accept-encoding header contains spaces between values #6951

Closed
sercand opened this issue Jan 31, 2024 · 0 comments · Fixed by #6952
Closed
Assignees

Comments

@sercand
Copy link
Contributor

sercand commented Jan 31, 2024

What version of gRPC are you using?

1.61.0

What version of Go are you using (go version)?

1.21.2

What operating system (Linux, Windows, …) and version?

macOS

What did you do?

Call grpc-go server from https://github.com/grpc/grpc client with compression enabled.

What did you expect to see?

grpc-core adds a whitespace character between values:

grpc-accept-encoding=identity, deflate, gzip

go server should accept this header.

What did you see instead?

There is no compression happened between server and client.
The reason for that the go code splits the value with , and doesn't trim the results.
The only valid header for go is the following:

grpc-accept-encoding=identity,deflate,gzip

grpc-dotnet repo is has done something similar before.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant